Commit 2d1a5f56 authored Aug 06, 2020 by Saurav Kashyap Committed by Greg Kroah-Hartman Sep 03, 2020

Revert "scsi: qla2xxx: Fix crash on qla2x00_mailbox_command"

[ Upstream commit de7e6194301ad31c4ce95395eb678e51a1b907e5 ]

FCoE adapter initialization failed for ISP8021 with the following patch
applied. In addition, reproduction of the issue the patch originally tried
to address has been unsuccessful.

This reverts commit 3cb182b3.

Link: https://lore.kernel.org/r/20200806111014.28434-11-njavali@marvell.com


Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f92ff03e

drivers/scsi/qla2xxx/qla_mbx.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -329,14 +329,6 @@ qla2x00_mailbox_command(scsi_qla_host_t vha, mbx_cmd_t mcp)
		if (time_after(jiffies, wait_time))
		break;

		/*
		* Check if it's UNLOADING, cause we cannot poll in
		* this case, or else a NULL pointer dereference
		* is triggered.
		*/
		if (unlikely(test_bit(UNLOADING, &base_vha->dpc_flags)))
		return QLA_FUNCTION_TIMEOUT;

		/* Check for pending interrupts. */
		qla2x00_poll(ha->rsp_q_map[0]);