Commit 2ce89942 authored Dec 04, 2016 by Pan Bian Committed by Mauro Carvalho Chehab Feb 03, 2017

[media] media: pci: meye: set error code on failures

The value of return variable ret is 0 on some error paths, for example,
when pci_resource_start() returns a NULL pointer. 0 means no error in
this context, which is contrary to the fact. This patch fixes the bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189011

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent d54a90c4

drivers/media/pci/meye/meye.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1659,6 +1659,7 @@ static int meye_probe(struct pci_dev pcidev, const struct pci_device_id ent)
		goto outenabledev;
		}

		ret = -EIO;
		mchip_adr = pci_resource_start(meye.mchip_dev,0);
		if (!mchip_adr) {
		v4l2_err(v4l2_dev, "meye: mchip has no device base address\n");