Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2cd575aa authored by Peter Rosin's avatar Peter Rosin Committed by Daniel Vetter
Browse files

drm: remove unused and redundant callbacks 



Drivers no longer have any need for these callbacks, and there are no
users. Zap. Zap-zap-zzzap-p-pp-p.

Acked-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarPeter Rosin <peda@axentia.se>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20170713162538.22788-15-peda@axentia.se
parent 1c4a5d3a

include/drm/drm_crtc.h

+0 −8
Original line number Diff line number Diff line
@@ -358,14 +358,6 @@ struct drm_crtc_funcs { 
	 * drm_crtc_enable_color_mgmt(), which then supports the legacy gamma

	 * interface through the drm_atomic_helper_legacy_gamma_set()

	 * compatibility implementation.

	 *

	 * NOTE:

	 *

	 * Drivers that support gamma tables and also fbdev emulation through

	 * the provided helper library need to take care to fill out the gamma

	 * hooks for both. Currently there's a bit an unfortunate duplication

	 * going on, which should eventually be unified to just one set of

	 * hooks.

	 */

	int (*gamma_set)(struct drm_crtc *crtc, u16 *r, u16 *g, u16 *b,

			 uint32_t size,

include/drm/drm_fb_helper.h

+0 −32
Original line number Diff line number Diff line
@@ -84,38 +84,6 @@ struct drm_fb_helper_surface_size { 
 * Driver callbacks used by the fbdev emulation helper library.

 */

struct drm_fb_helper_funcs {

	/**

	 * @gamma_set:

	 *

	 * Set the given gamma LUT register on the given CRTC.

	 *

	 * This callback is optional.

	 *

	 * FIXME:

	 *

	 * This callback is functionally redundant with the core gamma table

	 * support and simply exists because the fbdev hasn't yet been

	 * refactored to use the core gamma table interfaces.

	 */

	void (*gamma_set)(struct drm_crtc *crtc, u16 red, u16 green,

			  u16 blue, int regno);

	/**

	 * @gamma_get:

	 *

	 * Read the given gamma LUT register on the given CRTC, used to save the

	 * current LUT when force-restoring the fbdev for e.g. kdbg.

	 *

	 * This callback is optional.

	 *

	 * FIXME:

	 *

	 * This callback is functionally redundant with the core gamma table

	 * support and simply exists because the fbdev hasn't yet been

	 * refactored to use the core gamma table interfaces.

	 */

	void (*gamma_get)(struct drm_crtc *crtc, u16 *red, u16 *green,

			  u16 *blue, int regno);



	/**

	 * @fb_probe:

	 *

include/drm/drm_modeset_helper_vtables.h

+0 −16
Original line number Diff line number Diff line
@@ -266,22 +266,6 @@ struct drm_crtc_helper_funcs { 
				    struct drm_framebuffer *fb, int x, int y,

				    enum mode_set_atomic);



	/**

	 * @load_lut:

	 *

	 * Load a LUT prepared with the &drm_fb_helper_funcs.gamma_set vfunc.

	 *

	 * This callback is optional and is only used by the fbdev emulation

	 * helpers.

	 *

	 * FIXME:

	 *

	 * This callback is functionally redundant with the core gamma table

	 * support and simply exists because the fbdev hasn't yet been

	 * refactored to use the core gamma table interfaces.

	 */

	void (*load_lut)(struct drm_crtc *crtc);



	/**

	 * @disable:

	 *