Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c75bdf3 authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mark Brown
Browse files

ASoC: dapm: Fix kcontrol path list corruption 



When calling krealloc for the kcontrol data the items in the path list that
point back to the head of the list will now point to freed memory, which causes
the list to become corrupted. To fix this, instead of resizing the whole data
struct, only resize the widget list.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 9356e9d5

sound/soc/soc-dapm.c

+21 −17
Original line number Original line Diff line number Diff line
@@ -177,7 +177,7 @@ static inline struct snd_soc_dapm_widget *dapm_cnew_widget( 
struct dapm_kcontrol_data {

struct dapm_kcontrol_data {

	unsigned int value;

	unsigned int value;

	struct list_head paths;

	struct list_head paths;

	struct snd_soc_dapm_widget_list wlist;

	struct snd_soc_dapm_widget_list *wlist;

};

};





static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget,

static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget,
@@ -185,7 +185,7 @@ static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget, 
{

{

	struct dapm_kcontrol_data *data;

	struct dapm_kcontrol_data *data;





	data = kzalloc(sizeof(*data) + sizeof(widget), GFP_KERNEL);

	data = kzalloc(sizeof(*data), GFP_KERNEL);

	if (!data) {

	if (!data) {

		dev_err(widget->dapm->dev,

		dev_err(widget->dapm->dev,

				"ASoC: can't allocate kcontrol data for %s\n",

				"ASoC: can't allocate kcontrol data for %s\n",
@@ -193,8 +193,6 @@ static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget, 
		return -ENOMEM;

		return -ENOMEM;

	}

	}





	data->wlist.widgets[0] = widget;

	data->wlist.num_widgets = 1;

	INIT_LIST_HEAD(&data->paths);

	INIT_LIST_HEAD(&data->paths);





	kcontrol->private_data = data;

	kcontrol->private_data = data;
@@ -205,6 +203,7 @@ static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget, 
static void dapm_kcontrol_free(struct snd_kcontrol *kctl)

static void dapm_kcontrol_free(struct snd_kcontrol *kctl)

{

{

	struct dapm_kcontrol_data *data = snd_kcontrol_chip(kctl);

	struct dapm_kcontrol_data *data = snd_kcontrol_chip(kctl);

	kfree(data->wlist);

	kfree(data);

	kfree(data);

}

}
@@ -213,25 +212,30 @@ static struct snd_soc_dapm_widget_list *dapm_kcontrol_get_wlist( 
{

{

	struct dapm_kcontrol_data *data = snd_kcontrol_chip(kcontrol);

	struct dapm_kcontrol_data *data = snd_kcontrol_chip(kcontrol);





	return &data->wlist;

	return data->wlist;

}

}





static int dapm_kcontrol_add_widget(struct snd_kcontrol *kcontrol,

static int dapm_kcontrol_add_widget(struct snd_kcontrol *kcontrol,

	struct snd_soc_dapm_widget *widget)

	struct snd_soc_dapm_widget *widget)

{

{

	struct dapm_kcontrol_data *data = snd_kcontrol_chip(kcontrol);

	struct dapm_kcontrol_data *data = snd_kcontrol_chip(kcontrol);

	struct dapm_kcontrol_data *new_data;

	struct snd_soc_dapm_widget_list *new_wlist;

	unsigned int n = data->wlist.num_widgets + 1;

	unsigned int n;





	new_data = krealloc(data, sizeof(*data) + sizeof(widget) * n,

	if (data->wlist)

		GFP_KERNEL);

		n = data->wlist->num_widgets + 1;

	if (!new_data)

	else

		n = 1;



	new_wlist = krealloc(data->wlist,

			sizeof(*new_wlist) + sizeof(widget) * n, GFP_KERNEL);

	if (!new_wlist)

		return -ENOMEM;

		return -ENOMEM;





	new_data->wlist.widgets[n - 1] = widget;

	new_wlist->widgets[n - 1] = widget;

	new_data->wlist.num_widgets = n;

	new_wlist->num_widgets = n;





	kcontrol->private_data = new_data;

	data->wlist = new_wlist;





	return 0;

	return 0;

}

}
@@ -689,11 +693,11 @@ static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w, 
				w->name, name, ret);

				w->name, name, ret);

			return ret;

			return ret;

		}

		}

	} else {

	}



	ret = dapm_kcontrol_add_widget(kcontrol, w);

	ret = dapm_kcontrol_add_widget(kcontrol, w);

	if (ret)

	if (ret)

		return ret;

		return ret;

	}





	w->kcontrols[kci] = kcontrol;

	w->kcontrols[kci] = kcontrol;

	dapm_kcontrol_add_path(kcontrol, path);

	dapm_kcontrol_add_path(kcontrol, path);