Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c675218 authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: qedi: Fix return code in qedi_ep_connect() 



We shouldn't be writing over the "ret" variable.  It means we return
ERR_PTR(0) which is NULL and it results in a NULL dereference in the
caller.

Fixes: ace7f46b ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent cd069bb9

drivers/scsi/qedi/qedi_iscsi.c

+4 −4
Original line number Diff line number Diff line
@@ -824,7 +824,7 @@ qedi_ep_connect(struct Scsi_Host *shost, struct sockaddr *dst_addr, 
	u32 iscsi_cid = QEDI_CID_RESERVED;

	u16 len = 0;

	char *buf = NULL;

	int ret;

	int ret, tmp;



	if (!shost) {

		ret = -ENXIO;
@@ -940,10 +940,10 @@ qedi_ep_connect(struct Scsi_Host *shost, struct sockaddr *dst_addr, 


ep_rel_conn:

	qedi->ep_tbl[iscsi_cid] = NULL;

	ret = qedi_ops->release_conn(qedi->cdev, qedi_ep->handle);

	if (ret)

	tmp = qedi_ops->release_conn(qedi->cdev, qedi_ep->handle);

	if (tmp)

		QEDI_WARN(&qedi->dbg_ctx, "release_conn returned %d\n",

			  ret);

			  tmp);

ep_free_sq:

	qedi_free_sq(qedi, qedi_ep);

ep_conn_exit: