Commit 2c4951ad authored Mar 22, 2017 by Tobin C. Harding Committed by Greg Kroah-Hartman Mar 23, 2017

staging: ks7010: invert if statement conditionals



Checkpatch emits WARNING: Avoid multiple line dereference.

Function uses if statement blocks to guard the body of the
function. If we invert these conditionals and return, then the code
becomes more readable and subsequent code is indented less. The
checkpatch fix then follows trivially.

Invert conditionals, return from function if new conditional evaluates
to true. Reduce the level of indentation in subsequent code.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6ad6e21b

drivers/staging/ks7010/ks_hostif.c

+10 −10

Original line number	Diff line number	Diff line
		@@ -2607,17 +2607,17 @@ void hostif_sme_task(unsigned long dev)

		DPRINTK(3, "\n");

		if (priv->dev_state >= DEVICE_STATE_BOOT) {
		if (cnt_smeqbody(priv) > 0) {
		hostif_sme_execute(priv,
		priv->sme_i.event_buff[priv->sme_i.
		qhead]);
		if (priv->dev_state < DEVICE_STATE_BOOT)
		return;

		if (cnt_smeqbody(priv) <= 0)
		return;

		hostif_sme_execute(priv, priv->sme_i.event_buff[priv->sme_i.qhead]);
		inc_smeqhead(priv);
		if (cnt_smeqbody(priv) > 0)
		tasklet_schedule(&priv->sme_task);
		}
		}
		}

		/* send to Station Management Entity module */
		void hostif_sme_enqueue(struct ks_wlan_private *priv, unsigned short event)