Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2bf4b03b authored by Kangjie Lu's avatar Kangjie Lu Committed by Greg Kroah-Hartman
Browse files

regulator: tps65910: fix a missing check of return value 



[ Upstream commit cd07e3701fa6a4c68f8493ee1d12caa18d46ec6a ]

tps65910_reg_set_bits() may fail. The fix checks if it fails, and if so,
returns with its error code.

Signed-off-by: default avatarKangjie Lu <kjlu@umn.edu>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f0910af7

drivers/regulator/tps65910-regulator.c

+3 −1
Original line number Diff line number Diff line
@@ -1102,8 +1102,10 @@ static int tps65910_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, pmic);



	/* Give control of all register to control port */

	tps65910_reg_set_bits(pmic->mfd, TPS65910_DEVCTRL,

	err = tps65910_reg_set_bits(pmic->mfd, TPS65910_DEVCTRL,

				DEVCTRL_SR_CTL_I2C_SEL_MASK);

	if (err < 0)

		return err;



	switch (tps65910_chip_id(tps65910)) {

	case TPS65910: