Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2bd362d5 authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Greg Kroah-Hartman
Browse files

ppdev: fix memory leak 



The variable name was only released if parport_register_dev_model()
fails. Now that we are using the device-model the parport driver
will duplicate the name and use it. So we can release the variable
after the device has been registered with the parport.

Suggested-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9ff2007b

drivers/char/ppdev.c

+1 −1
Original line number Diff line number Diff line
@@ -305,10 +305,10 @@ static int register_device(int minor, struct pp_struct *pp) 
	ppdev_cb.private = pp;

	pdev = parport_register_dev_model(port, name, &ppdev_cb, minor);

	parport_put_port(port);

	kfree(name);



	if (!pdev) {

		printk(KERN_WARNING "%s: failed to register device!\n", name);

		kfree(name);

		return -ENXIO;

	}