Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2bd197df authored by Tetsuo Handa's avatar Tetsuo Handa Committed by Greg Kroah-Hartman
Browse files

lockdep: Add a missing initialization hint to the "INFO: Trying to register non-static key" message 



[ Upstream commit 3a85969e9d912d5dd85362ee37b5f81266e00e77 ]

Since this message is printed when dynamically allocated spinlocks (e.g.
kzalloc()) are used without initialization (e.g. spin_lock_init()),
suggest to developers to check whether initialization functions for objects
were called, before making developers wonder what annotation is missing.

[ mingo: Minor tweaks to the message. ]

Signed-off-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210321064913.4619-1-penguin-kernel@I-love.SAKURA.ne.jp


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent c5d6a661

kernel/locking/lockdep.c

+2 −1
Original line number Diff line number Diff line
@@ -722,7 +722,8 @@ static bool assign_lock_key(struct lockdep_map *lock) 
		/* Debug-check: all keys must be persistent! */

		debug_locks_off();

		pr_err("INFO: trying to register non-static key.\n");

		pr_err("the code is fine but needs lockdep annotation.\n");

		pr_err("The code is fine but needs lockdep annotation, or maybe\n");

		pr_err("you didn't initialize this object before use?\n");

		pr_err("turning off the locking correctness validator.\n");

		dump_stack();

		return false;