Commit 2b387059 authored Nov 24, 2014 by Chris Wilson Committed by Daniel Vetter Dec 03, 2014

drm/i915: Only warn the first time we attempt to mmio whilst suspended



In all likelihood we will do a few hundred errnoneous register
operations if we do a single invalid register access whilst the device
is suspended. As each instance causes a WARN, this floods the system
logs and can make the system unresponsive.

The warning was first introduced in
commit b2ec142c
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Date:   Fri Feb 21 13:52:25 2014 -0300

    drm/i915: call assert_device_not_suspended at gen6_force_wake_work

and despite the claims the WARN is still encountered in the wild today.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

parent b4eb1564

drivers/gpu/drm/i915/intel_uncore.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -43,7 +43,7 @@
		static void
		assert_device_not_suspended(struct drm_i915_private *dev_priv)
		{
		WARN(HAS_RUNTIME_PM(dev_priv->dev) && dev_priv->pm.suspended,
		WARN_ONCE(HAS_RUNTIME_PM(dev_priv->dev) && dev_priv->pm.suspended,
		"Device suspended\n");
		}