Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b002c30 authored by yuan linyu's avatar yuan linyu Committed by Greg Kroah-Hartman
Browse files

usb: udc: remove warning when queue disabled ep 



commit 2a587a035214fa1b5ef598aea0b81848c5b72e5e upstream.

It is possible trigger below warning message from mass storage function,

WARNING: CPU: 6 PID: 3839 at drivers/usb/gadget/udc/core.c:294 usb_ep_queue+0x7c/0x104
pc : usb_ep_queue+0x7c/0x104
lr : fsg_main_thread+0x494/0x1b3c

Root cause is mass storage function try to queue request from main thread,
but other thread may already disable ep when function disable.

As there is no function failure in the driver, in order to avoid effort
to fix warning, change WARN_ON_ONCE() in usb_ep_queue() to pr_debug().

Suggested-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Cc: stable@vger.kernel.org
Signed-off-by: default avataryuan linyu <yuanlinyu@hihonor.com>
Reviewed-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20240315020144.2715575-1-yuanlinyu@hihonor.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d32e8f2f

drivers/usb/gadget/udc/core.c

+3 −1
Original line number Diff line number Diff line
@@ -273,7 +273,9 @@ int usb_ep_queue(struct usb_ep *ep, 
{

	int ret = 0;



	if (WARN_ON_ONCE(!ep->enabled && ep->address)) {

	if (!ep->enabled && ep->address) {

		pr_debug("USB gadget: queue request to disabled ep 0x%x (%s)\n",

				 ep->address, ep->name);

		ret = -ESHUTDOWN;

		goto out;

	}