Commit 2af86f9d authored Jul 15, 2016 by Karthik D A Committed by Kalle Valo Jul 18, 2016

mwifiex: Fix request_irq() failure handling



It's been observed that request_irq() failure leads to a system crash
due to a bug in mwifiex driver.
When this failure happens, mwifiex_add_card() already takes care of
clearing and freeing adapter->card pointer. This patch removes the
redundant cleanup code causing crash.

Signed-off-by: Karthik D A <karthida@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent fd3ed33f

drivers/net/wireless/marvell/mwifiex/pcie.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -202,7 +202,6 @@ static int mwifiex_pcie_probe(struct pci_dev *pdev,
		if (mwifiex_add_card(card, &add_remove_card_sem, &pcie_ops,
		MWIFIEX_PCIE)) {
		pr_err("%s failed\n", __func__);
		kfree(card);
		return -1;
		}

		@@ -2843,7 +2842,6 @@ static int mwifiex_pcie_request_irq(struct mwifiex_adapter *adapter)
		"MRVL_PCIE", &card->share_irq_ctx);
		if (ret) {
		pr_err("request_irq failed: ret=%d\n", ret);
		adapter->card = NULL;
		return -1;
		}