Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Verified Commit 2a91e9ef authored by Park Ju Hyung's avatar Park Ju Hyung Committed by Ahmed Harhash
Browse files

trace: add CONFIG_DISABLE_TRACE_PRINTK option 



Poorly made kernel trees often use trace_printk() without
properly guarding them in a #ifdef macro.
Such usage of trace_printk() causes a warning at
boot and additional memory allocation.

This option serves to disable those all at once with ease.

Change-Id: I2cb2085f48064bda8c18806597c5aee57237dca6
Signed-off-by: default avatarPark Ju Hyung <qkrwngud825@gmail.com>
Signed-off-by: default avatarAlex Naidis <alex.naidis@linux.com>
parent 3724b839

include/linux/kernel.h

+4 −0
Original line number Diff line number Diff line
@@ -686,6 +686,9 @@ do { \ 
 * let gcc optimize the rest.

 */



#ifdef CONFIG_DISABLE_TRACE_PRINTK

#define trace_printk pr_debug

#else

#define trace_printk(fmt, ...)				\

do {							\

	char _______STR[] = __stringify((__VA_ARGS__));	\
@@ -708,6 +711,7 @@ do { \ 
	else								\

		__trace_printk(_THIS_IP_, fmt, ##args);			\

} while (0)

#endif



extern __printf(2, 3)

int __trace_bprintk(unsigned long ip, const char *fmt, ...);

kernel/trace/Kconfig

+14 −0
Original line number Diff line number Diff line
@@ -146,6 +146,20 @@ config GENERIC_TRACER 
	bool

	select TRACING



if TRACING



config DISABLE_TRACE_PRINTK

	bool "Force disable trace_printk() usage"

	default y

	help

	  When trace_printk() is used in any of the kernel source, it enables

	  debugging functions which are not desired for production kernel.

	  Enabling this option will replace trace_printk() with pr_debug().



	  If in doubt, say Y.



endif



#

# Minimum requirements an architecture has to meet for us to

# be able to offer generic tracing facilities: