Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a7d44f4 authored by Alex Deucher's avatar Alex Deucher
Browse files

drm/radeon/dpm: don't add pwm attributes if DPM is disabled 

PWM fan control is only available with DPM.  If DPM disabled,
don't expose the PWM fan controls to avoid a crash.

Bug:
https://bugs.freedesktop.org/show_bug.cgi?id=92524



Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
parent f6c7aba4

drivers/gpu/drm/radeon/radeon_pm.c

+6 −2
Original line number Diff line number Diff line
@@ -717,10 +717,14 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj, 
	struct radeon_device *rdev = dev_get_drvdata(dev);

	umode_t effective_mode = attr->mode;



	/* Skip limit attributes if DPM is not enabled */

	/* Skip attributes if DPM is not enabled */

	if (rdev->pm.pm_method != PM_METHOD_DPM &&

	    (attr == &sensor_dev_attr_temp1_crit.dev_attr.attr ||

	     attr == &sensor_dev_attr_temp1_crit_hyst.dev_attr.attr))

	     attr == &sensor_dev_attr_temp1_crit_hyst.dev_attr.attr ||

	     attr == &sensor_dev_attr_pwm1.dev_attr.attr ||

	     attr == &sensor_dev_attr_pwm1_enable.dev_attr.attr ||

	     attr == &sensor_dev_attr_pwm1_max.dev_attr.attr ||

	     attr == &sensor_dev_attr_pwm1_min.dev_attr.attr))

		return 0;



	/* Skip fan attributes if fan is not present */