Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a7b29c5 authored by Bhanu Prakash Gollapudi's avatar Bhanu Prakash Gollapudi Committed by James Bottomley
Browse files

[SCSI] bnx2fc: fix panic in bnx2fc_post_io_req 



System panics while accessing stale pointer - timer_work_queue - in the IO path
before bnx2fc_stop is called. Fix is to destroy the workqueue after the destroy
operation is complete.

Signed-off-by: default avatarBhanu Prakash Gollapudi <bprakash@broadcom.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 9f71af2f

drivers/scsi/bnx2fc/bnx2fc_fcoe.c

+3 −2
Original line number Diff line number Diff line
@@ -1537,6 +1537,7 @@ static void __bnx2fc_destroy(struct bnx2fc_interface *interface) 
static int bnx2fc_destroy(struct net_device *netdev)

{

	struct bnx2fc_interface *interface = NULL;

	struct workqueue_struct *timer_work_queue;

	int rc = 0;



	rtnl_lock();
@@ -1549,9 +1550,9 @@ static int bnx2fc_destroy(struct net_device *netdev) 
		goto netdev_err;

	}





	destroy_workqueue(interface->timer_work_queue);

	timer_work_queue = interface->timer_work_queue;

	__bnx2fc_destroy(interface);

	destroy_workqueue(timer_work_queue);



netdev_err:

	mutex_unlock(&bnx2fc_dev_lock);