Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a71de2f authored by Lukas Wunner's avatar Lukas Wunner Committed by Greg Kroah-Hartman
Browse files

serial: omap: Fix EFR write on RTS deassertion 



Commit 348f9bb3 ("serial: omap: Fix RTS handling") sought to enable
auto RTS upon manual RTS assertion and disable it on deassertion.
However it seems the latter was done incorrectly, it clears all bits in
the Extended Features Register *except* auto RTS.

Fixes: 348f9bb3 ("serial: omap: Fix RTS handling")
Cc: Peter Hurley <peter@hurleysoftware.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarLukas Wunner <lukas@wunner.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e60f9fd0

drivers/tty/serial/omap-serial.c

+1 −1
Original line number Diff line number Diff line
@@ -693,7 +693,7 @@ static void serial_omap_set_mctrl(struct uart_port *port, unsigned int mctrl) 
	if ((mctrl & TIOCM_RTS) && (port->status & UPSTAT_AUTORTS))

		up->efr |= UART_EFR_RTS;

	else

		up->efr &= UART_EFR_RTS;

		up->efr &= ~UART_EFR_RTS;

	serial_out(up, UART_EFR, up->efr);

	serial_out(up, UART_LCR, lcr);