Commit 2a458edd authored Apr 12, 2019 by Sabrina Dubroca Committed by Greg Kroah-Hartman Apr 27, 2019

bonding: fix event handling for stacked bonds



[ Upstream commit 92480b3977fd3884649d404cbbaf839b70035699 ]

When a bond is enslaved to another bond, bond_netdev_event() only
handles the event as if the bond is a master, and skips treating the
bond as a slave.

This leads to a refcount leak on the slave, since we don't remove the
adjacency to its master and the master holds a reference on the slave.

Reproducer:
  ip link add bondL type bond
  ip link add bondU type bond
  ip link set bondL master bondU
  ip link del bondL

No "Fixes:" tag, this code is older than git history.

Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c98875d9

drivers/net/bonding/bond_main.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -3198,8 +3198,12 @@ static int bond_netdev_event(struct notifier_block *this,
		return NOTIFY_DONE;

		if (event_dev->flags & IFF_MASTER) {
		int ret;

		netdev_dbg(event_dev, "IFF_MASTER\n");
		return bond_master_netdev_event(event, event_dev);
		ret = bond_master_netdev_event(event, event_dev);
		if (ret != NOTIFY_DONE)
		return ret;
		}

		if (event_dev->flags & IFF_SLAVE) {