Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 29838a5c authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Mark Brown
Browse files

ASoC: rt5514: Fix rt5514_spi_burst_read() buffer passing 



rt5514_dsp_voice_wake_up_put() passes "(u8 *)&buf" to
rt5514_spi_burst_read(), where the cast is needed to silence a compiler
warning:

    sound/soc/codecs/rt5514.c: In function ‘rt5514_dsp_voice_wake_up_put’:
    sound/soc/codecs/rt5514.c:357: warning: passing argument 2 of ‘rt5514_spi_burst_read’ from incompatible pointer type

However, as the variable is declared as an array ("u8 buf[8]"), the
function should just pass "buf" instead.

Fixes: fc9cab05 ("ASoC: rt5514: The DSP clock can be calibrated by the other clock source")
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 04e8262a

sound/soc/codecs/rt5514.c

+1 −2
Original line number Diff line number Diff line
@@ -353,8 +353,7 @@ static int rt5514_dsp_voice_wake_up_put(struct snd_kcontrol *kcontrol, 
				msleep(20);

#if IS_ENABLED(CONFIG_SND_SOC_RT5514_SPI)

				rt5514_spi_burst_read(RT5514_PLL3_CALIB_CTRL6 |

					RT5514_DSP_MAPPING,

					(u8 *)&buf, sizeof(buf));

					RT5514_DSP_MAPPING, buf, sizeof(buf));

#else

				dev_err(component->dev, "There is no SPI driver for"

					" loading the firmware\n");