Commit 29376bc7 authored Jun 19, 2011 by Mark Brown

ASoC: Fix DAPM sequence run for per-widget I/O methods



Previously we were using the DAPM context rather than a widget as the
argument for update_bits() so we didn't need to care that our list walk
of widgets left us one beyond the end of the list. Now we're using them
for the register update we need to make sure we're pointing at an actual
widget not the list_head.

Fix originally suggested by Liam on IM.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@ti.com>

parent ee8c7e97

sound/soc/soc-dapm.c

+6 −0

Original line number	Original line	Diff line number	Diff line
	@@ -918,6 +918,12 @@ static void dapm_seq_run_coalesced(struct snd_soc_dapm_context *dapm,
	}		}

	if (reg >= 0) {		if (reg >= 0) {
			/* Any widget will do, they should all be updating the
			* same register.
			*/
			w = list_first_entry(pending, struct snd_soc_dapm_widget,
			power_list);

	pop_dbg(dapm->dev, card->pop_time,		pop_dbg(dapm->dev, card->pop_time,
	"pop test : Applying 0x%x/0x%x to %x in %dms\n",		"pop test : Applying 0x%x/0x%x to %x in %dms\n",
	value, mask, reg, card->pop_time);		value, mask, reg, card->pop_time);