Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28f88810 authored by Sachin Prabhu's avatar Sachin Prabhu Committed by Steve French
Browse files

Use correct conversion specifiers in cifs_show_options 



cifs_show_options uses the wrong conversion specifier for uid, gid,
rsize & wsize. Correct this to %u to match it to the variable type
'unsigned integer'.

Signed-off-by: default avatarSachin Prabhu <sprabhu@redhat.com>
Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 3c7c87fd

fs/cifs/cifsfs.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -370,13 +370,13 @@ cifs_show_options(struct seq_file *s, struct dentry *root) 
				   (int)(srcaddr->sa_family));

				   (int)(srcaddr->sa_family));

	}

	}





	seq_printf(s, ",uid=%d", cifs_sb->mnt_uid);

	seq_printf(s, ",uid=%u", cifs_sb->mnt_uid);

	if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_OVERR_UID)

	if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_OVERR_UID)

		seq_printf(s, ",forceuid");

		seq_printf(s, ",forceuid");

	else

	else

		seq_printf(s, ",noforceuid");

		seq_printf(s, ",noforceuid");





	seq_printf(s, ",gid=%d", cifs_sb->mnt_gid);

	seq_printf(s, ",gid=%u", cifs_sb->mnt_gid);

	if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_OVERR_GID)

	if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_OVERR_GID)

		seq_printf(s, ",forcegid");

		seq_printf(s, ",forcegid");

	else

	else
@@ -439,8 +439,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root) 
	if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_CIFS_BACKUPGID)

	if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_CIFS_BACKUPGID)

		seq_printf(s, ",backupgid=%u", cifs_sb->mnt_backupgid);

		seq_printf(s, ",backupgid=%u", cifs_sb->mnt_backupgid);





	seq_printf(s, ",rsize=%d", cifs_sb->rsize);

	seq_printf(s, ",rsize=%u", cifs_sb->rsize);

	seq_printf(s, ",wsize=%d", cifs_sb->wsize);

	seq_printf(s, ",wsize=%u", cifs_sb->wsize);

	/* convert actimeo and display it in seconds */

	/* convert actimeo and display it in seconds */

		seq_printf(s, ",actimeo=%lu", cifs_sb->actimeo / HZ);

		seq_printf(s, ",actimeo=%lu", cifs_sb->actimeo / HZ);