Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28e3a8f3 authored by Eddie Wai's avatar Eddie Wai Committed by David S. Miller
Browse files

cnic: Add missing error checking for RAMROD_CMD_ID_CLOSE 



Completion status field should also be checked for non-zero error
condition.

Signed-off-by: default avatarEddie Wai <eddie.wai@broadcom.com>
Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b3bd2d65

drivers/net/ethernet/broadcom/cnic.c

+7 −4
Original line number Diff line number Diff line
@@ -4022,15 +4022,18 @@ static void cnic_cm_process_kcqe(struct cnic_dev *dev, struct kcqe *kcqe) 
		cnic_cm_upcall(cp, csk, opcode);

		break;



	case L5CM_RAMROD_CMD_ID_CLOSE:

		if (l4kcqe->status != 0) {

			netdev_warn(dev->netdev, "RAMROD CLOSE compl with "

				    "status 0x%x\n", l4kcqe->status);

	case L5CM_RAMROD_CMD_ID_CLOSE: {

		struct iscsi_kcqe *l5kcqe = (struct iscsi_kcqe *) kcqe;



		if (l4kcqe->status != 0 || l5kcqe->completion_status != 0) {

			netdev_warn(dev->netdev, "RAMROD CLOSE compl with status 0x%x completion status 0x%x\n",

				    l4kcqe->status, l5kcqe->completion_status);

			opcode = L4_KCQE_OPCODE_VALUE_CLOSE_COMP;

			/* Fall through */

		} else {

			break;

		}

	}

	case L4_KCQE_OPCODE_VALUE_RESET_RECEIVED:

	case L4_KCQE_OPCODE_VALUE_CLOSE_COMP:

	case L4_KCQE_OPCODE_VALUE_RESET_COMP: