Commit 288320f6 authored May 30, 2018 by Colin Ian King Committed by Jonathan Cameron Jun 24, 2018

iio: tsl2x7x/tsl2772: avoid potential division by zero



It may be possible for tsl2772_get_lux to return a zero lux value
and hence a division by zero can occur when lux_val is zero. Check
for this case and return -ERANGE to avoid the division by zero.

Detected by CoverityScan, CID#1469484 ("Division or modulo by zero")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 13399ff2

drivers/iio/light/tsl2772.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -582,6 +582,8 @@ static int tsl2772_als_calibrate(struct iio_dev *indio_dev)
		"%s: failed to get lux\n", __func__);
		return lux_val;
		}
		if (lux_val == 0)
		return -ERANGE;

		ret = (chip->settings.als_cal_target * chip->settings.als_gain_trim) /
		lux_val;