Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28518c91 authored by Sebastian Krzyszkowiak's avatar Sebastian Krzyszkowiak Committed by Greg Kroah-Hartman
Browse files

power: supply: max17042_battery: Prevent int underflow in set_soc_threshold 



commit e660dbb68c6b3f7b9eb8b9775846a44f9798b719 upstream.

max17042_set_soc_threshold gets called with offset set to 1, which means
that minimum threshold value would underflow once SOC got down to 0,
causing invalid alerts from the gauge.

Fixes: e5f3872d ("max17042: Add support for signalling change in SOC")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarSebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ba3f578b

drivers/power/supply/max17042_battery.c

+2 −1
Original line number Diff line number Diff line
@@ -848,7 +848,8 @@ static void max17042_set_soc_threshold(struct max17042_chip *chip, u16 off) 
	regmap_read(map, MAX17042_RepSOC, &soc);

	soc >>= 8;

	soc_tr = (soc + off) << 8;

	soc_tr |= (soc - off);

	if (off < soc)

		soc_tr |= soc - off;

	regmap_write(map, MAX17042_SALRT_Th, soc_tr);

}