Commit 2829c806 authored Jul 29, 2024 by Tetsuo Handa Committed by Greg Kroah-Hartman Sep 04, 2024

Input: MT - limit max slots

commit 99d3bf5f7377d42f8be60a6b9cb60fb0be34dceb upstream.

syzbot is reporting too large allocation at input_mt_init_slots(), for
num_slots is supplied from userspace using ioctl(UI_DEV_CREATE).

Since nobody knows possible max slots, this patch chose 1024.

Reported-by: syzbot <syzbot+0122fa359a69694395d5@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=0122fa359a69694395d5

Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: George Kennedy <george.kennedy@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent aea24ef5

drivers/input/input-mt.c

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -48,6 +48,9 @@ int input_mt_init_slots(struct input_dev *dev, unsigned int num_slots,
	return 0;		return 0;
	if (mt)		if (mt)
	return mt->num_slots != num_slots ? -EINVAL : 0;		return mt->num_slots != num_slots ? -EINVAL : 0;
			/* Arbitrary limit for avoiding too large memory allocation. */
			if (num_slots > 1024)
			return -EINVAL;

	mt = kzalloc(struct_size(mt, slots, num_slots), GFP_KERNEL);		mt = kzalloc(struct_size(mt, slots, num_slots), GFP_KERNEL);
	if (!mt)		if (!mt)