Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27e4f9d0 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar
Browse files

sched/wait: Explain the shadowing and type inconsistencies 



Stick in a comment before someone else tries to fix the sparse warning
this generates.

Requested-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarPeter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/n/tip-o2ro6f3vkxklni0bc8f7m68s@git.kernel.org


Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent cadefd3d

include/linux/wait.h

+13 −1
Original line number Diff line number Diff line
@@ -191,11 +191,23 @@ wait_queue_head_t *bit_waitqueue(void *, int); 
	(!__builtin_constant_p(state) ||				\

		state == TASK_INTERRUPTIBLE || state == TASK_KILLABLE)	\



/*

 * The below macro ___wait_event() has an explicit shadow of the __ret

 * variable when used from the wait_event_*() macros.

 *

 * This is so that both can use the ___wait_cond_timeout() construct

 * to wrap the condition.

 *

 * The type inconsistency of the wait_event_*() __ret variable is also

 * on purpose; we use long where we can return timeout values and int

 * otherwise.

 */



#define ___wait_event(wq, condition, state, exclusive, ret, cmd)	\

({									\

	__label__ __out;						\

	wait_queue_t __wait;						\

	long __ret = ret;						\

	long __ret = ret;	/* explicit shadow */			\

									\

	INIT_LIST_HEAD(&__wait.task_list);				\

	if (exclusive)							\