Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 276b7361 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Marc Kleine-Budde
Browse files

can: sja1000: Replace mdelay with usleep_range in peak_pci_probe 



peak_pci_probe() is never called in atomic context.

peak_pci_probe() is set as ".probe" in struct pci_driver.

Despite never getting called from atomic context, peak_pci_probe()
calls mdelay() to busily wait.
This is not necessary and can be replaced with usleep_range() to
avoid busy waiting.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 5b749be3

drivers/net/can/sja1000/peak_pci.c

+1 −1
Original line number Diff line number Diff line
@@ -608,7 +608,7 @@ static int peak_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	writeb(0x00, cfg_base + PITA_GPIOICR);

	/* Toggle reset */

	writeb(0x05, cfg_base + PITA_MISC + 3);

	mdelay(5);

	usleep_range(5000, 6000);

	/* Leave parport mux mode */

	writeb(0x04, cfg_base + PITA_MISC + 3);