Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2630bae8 authored by Eran Ben Elisha's avatar Eran Ben Elisha Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix quota counting in aRFS expire flow 



Quota should follow the amount of rules which do expire, and not the
number of rules that were examined, fixed that.

Fixes: 18c908e4 ("net/mlx5e: Add accelerated RFS support")
Signed-off-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
Reviewed-by: default avatarMaor Gottlieb <maorg@mellanox.com>
Reviewed-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 33180bee

drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c

+2 −2
Original line number Diff line number Diff line
@@ -381,14 +381,14 @@ static void arfs_may_expire_flow(struct mlx5e_priv *priv) 
	HLIST_HEAD(del_list);

	spin_lock_bh(&priv->fs.arfs.arfs_lock);

	mlx5e_for_each_arfs_rule(arfs_rule, htmp, priv->fs.arfs.arfs_tables, i, j) {

		if (quota++ > MLX5E_ARFS_EXPIRY_QUOTA)

			break;

		if (!work_pending(&arfs_rule->arfs_work) &&

		    rps_may_expire_flow(priv->netdev,

					arfs_rule->rxq, arfs_rule->flow_id,

					arfs_rule->filter_id)) {

			hlist_del_init(&arfs_rule->hlist);

			hlist_add_head(&arfs_rule->hlist, &del_list);

			if (quota++ > MLX5E_ARFS_EXPIRY_QUOTA)

				break;

		}

	}

	spin_unlock_bh(&priv->fs.arfs.arfs_lock);