Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25fe7b0d authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

clk: ti: dra7-atl: Fix reference leak in of_dra7_atl_clk_probe 



[ Upstream commit 9c59a01caba26ec06fefd6ca1f22d5fd1de57d63 ]

pm_runtime_get_sync() will increment pm usage counter.
Forgetting to putting operation will result in reference leak.
Add missing pm_runtime_put_sync in some error paths.

Fixes: 9ac33b0c ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220602030838.52057-1-linmq006@gmail.com


Reviewed-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 637f609d

drivers/clk/ti/clk-dra7-atl.c

+6 −3
Original line number Diff line number Diff line
@@ -252,14 +252,16 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev) 
		if (rc) {

			pr_err("%s: failed to lookup atl clock %d\n", __func__,

			       i);

			return -EINVAL;

			ret = -EINVAL;

			goto pm_put;

		}



		clk = of_clk_get_from_provider(&clkspec);

		if (IS_ERR(clk)) {

			pr_err("%s: failed to get atl clock %d from provider\n",

			       __func__, i);

			return PTR_ERR(clk);

			ret = PTR_ERR(clk);

			goto pm_put;

		}



		cdesc = to_atl_desc(__clk_get_hw(clk));
@@ -292,8 +294,9 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev) 
		if (cdesc->enabled)

			atl_clk_enable(__clk_get_hw(clk));

	}

	pm_runtime_put_sync(cinfo->dev);



pm_put:

	pm_runtime_put_sync(cinfo->dev);

	return ret;

}