Commit 25f6ba48 authored Dec 05, 2020 by Hannes Reinecke Committed by Greg Kroah-Hartman May 22, 2021

nvme: retrigger ANA log update if group descriptor isn't found



[ Upstream commit dd8f7fa908f66dd44abcd83cbb50410524b9f8ef ]

If ANA is enabled but no ANA group descriptor is found when creating
a new namespace the ANA log is most likely out of date, so trigger
a re-read. The namespace will be tagged with the NS_ANA_PENDING flag
to exclude it from path selection until the ANA log has been re-read.

Fixes: 32acab31 ("nvme: implement multipath access to nvme subsystems")
Reported-by: Martin George <marting@netapp.com>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 77b2bc23

drivers/nvme/host/multipath.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -516,6 +516,10 @@ void nvme_mpath_add_disk(struct nvme_ns ns, struct nvme_id_ns id)
		if (desc.state) {
		/* found the group desc: update */
		nvme_update_ns_ana_state(&desc, ns);
		} else {
		/* group desc not found: trigger a re-read */
		set_bit(NVME_NS_ANA_PENDING, &ns->flags);
		queue_work(nvme_wq, &ns->ctrl->ana_work);
		}
		} else {
		mutex_lock(&ns->head->lock);