Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25c7ce7f authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Tejun Heo
Browse files

libata: cleanup ata_scsi_qc_complete 



Remove an incorrect comment and untangle an if statement in
ata_scsi_qc_complete.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 8a3e33cf

drivers/ata/libata-scsi.c

+5 −14
Original line number Diff line number Diff line
@@ -1774,21 +1774,12 @@ static void ata_scsi_qc_complete(struct ata_queued_cmd *qc) 
	 * asc,ascq = ATA PASS-THROUGH INFORMATION AVAILABLE

	 */

	if (((cdb[0] == ATA_16) || (cdb[0] == ATA_12)) &&

	    ((cdb[2] & 0x20) || need_sense)) {

	    ((cdb[2] & 0x20) || need_sense))

		ata_gen_passthru_sense(qc);

	} else {

		if (!need_sense) {

			cmd->result = SAM_STAT_GOOD;

		} else {

			/* TODO: decide which descriptor format to use

			 * for 48b LBA devices and call that here

			 * instead of the fixed desc, which is only

			 * good for smaller LBA (and maybe CHS?)

			 * devices.

			 */

	else if (need_sense)

		ata_gen_ata_sense(qc);

		}

	}

	else

		cmd->result = SAM_STAT_GOOD;



	if (need_sense && !ap->ops->error_handler)

		ata_dump_status(ap->print_id, &qc->result_tf);