Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25afffe1 authored by Daniel Baluta's avatar Daniel Baluta Committed by Jonathan Cameron
Browse files

io: accel: kxcjk-1013: Fix iio_event_spec direction 



Because IIO_EV_DIR_* are not bitmasks but enums,
IIO_EV_DIR_RISING | IIO_EV_DIR_FALLING is not equal
with IIO_EV_DIR_EITHER.

This could lead to potential misformatted sysfs attributes
like:
	* in_accel_x_thresh_(null)_en
	* in_accel_x_thresh_(null)_period
	* in_accel_x_thresh_(null)_value

or even memory corruption.

Fixes: b4b491c0 (iio: accel: kxcjk-1013: Support threshold)
Signed-off-by: default avatarDaniel Baluta <daniel.baluta@intel.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 03045bcf

drivers/iio/accel/kxcjk-1013.c

+1 −1
Original line number Diff line number Diff line
@@ -894,7 +894,7 @@ static const struct attribute_group kxcjk1013_attrs_group = { 


static const struct iio_event_spec kxcjk1013_event = {

		.type = IIO_EV_TYPE_THRESH,

		.dir = IIO_EV_DIR_RISING | IIO_EV_DIR_FALLING,

		.dir = IIO_EV_DIR_EITHER,

		.mask_separate = BIT(IIO_EV_INFO_VALUE) |

				 BIT(IIO_EV_INFO_ENABLE) |

				 BIT(IIO_EV_INFO_PERIOD)