Unverified Commit 2589bd82 authored Apr 09, 2018 by Jia-Ju Bai Committed by Mark Brown Apr 16, 2018

ASoC: intel: cht_bsw_max98090_ti: Replace GFP_ATOMIC with GFP_KERNEL in snd_cht_mc_probe



snd_cht_mc_probe() is never called in atomic context.
This function is only set as ".probe" in "struct platform_driver".

Despite never getting called from atomic context,
snd_cht_mc_probe() calls devm_kzalloc() with GFP_ATOMIC,
which waits busily for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
to avoid busy waiting and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 7a3a6323

sound/soc/intel/boards/cht_bsw_max98090_ti.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -391,7 +391,7 @@ static int snd_cht_mc_probe(struct platform_device *pdev)
	int ret_val = 0;		int ret_val = 0;
	struct cht_mc_private *drv;		struct cht_mc_private *drv;

	drv = devm_kzalloc(&pdev->dev, sizeof(*drv), GFP_ATOMIC);		drv = devm_kzalloc(&pdev->dev, sizeof(*drv), GFP_KERNEL);
	if (!drv)		if (!drv)
	return -ENOMEM;		return -ENOMEM;