Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 256e2fdf authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Greg Kroah-Hartman
Browse files

Fix Off-by-one in /sys/module/*/refcnt 



sysfs internals were changed to not pin module in question.

Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Acked-by: default avatarKay Sievers <kay.sievers@vrfy.org>
Acked-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 6cb52147

kernel/module.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -784,8 +784,7 @@ EXPORT_SYMBOL_GPL(symbol_put_addr); 
static ssize_t show_refcnt(struct module_attribute *mattr,

static ssize_t show_refcnt(struct module_attribute *mattr,

			   struct module *mod, char *buffer)

			   struct module *mod, char *buffer)

{

{

	/* sysfs holds a reference */

	return sprintf(buffer, "%u\n", module_refcount(mod));

	return sprintf(buffer, "%u\n", module_refcount(mod)-1);

}

}





static struct module_attribute refcnt = {

static struct module_attribute refcnt = {