Commit 25242703 authored Apr 30, 2018 by Gustavo A. R. Silva Committed by Greg Kroah-Hartman Apr 30, 2018

typec: tcpm: Fix incorrect 'and' operator

Currently, logical and is being used instead of *bitwise* and.

Fix this by using a proper bitwise and operator.

Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator")
Fixes: 64f7c494 ("typec: tcpm: Add support for sink PPS related messages")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 890fa45d

drivers/usb/typec/tcpm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1772,7 +1772,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port *port,
		enum pd_ext_msg_type type = pd_header_type_le(msg->header);
		unsigned int data_size = pd_ext_header_data_size_le(msg->ext_msg.header);

		if (!(msg->ext_msg.header && PD_EXT_HDR_CHUNKED)) {
		if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) {
		tcpm_log(port, "Unchunked extended messages unsupported");
		return;
		}