Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 24f41534 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Greg Kroah-Hartman
Browse files

ACPI: PM: Avoid attaching ACPI PM domain to certain devices 



commit b9ea0bae260f6aae546db224daa6ac1bd9d94b91 upstream.

Certain ACPI-enumerated devices represented as platform devices in
Linux, like fans, require special low-level power management handling
implemented by their drivers that is not in agreement with the ACPI
PM domain behavior.  That leads to problems with managing ACPI fans
during system-wide suspend and resume.

For this reason, make acpi_dev_pm_attach() skip the affected devices
by adding a list of device IDs to avoid to it and putting the IDs of
the affected devices into that list.

Fixes: e5cc8ef3 (ACPI / PM: Provide ACPI PM callback routines for subsystems)
Reported-by: default avatarZhang Rui <rui.zhang@intel.com>
Tested-by: default avatarTodd Brandt <todd.e.brandt@linux.intel.com>
Cc: 3.10+ <stable@vger.kernel.org> # 3.10+
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1309b436

drivers/acpi/device_pm.c

+11 −1
Original line number Diff line number Diff line
@@ -1254,9 +1254,19 @@ static void acpi_dev_pm_detach(struct device *dev, bool power_off) 
 */

int acpi_dev_pm_attach(struct device *dev, bool power_on)

{

	/*

	 * Skip devices whose ACPI companions match the device IDs below,

	 * because they require special power management handling incompatible

	 * with the generic ACPI PM domain.

	 */

	static const struct acpi_device_id special_pm_ids[] = {

		{"PNP0C0B", }, /* Generic ACPI fan */

		{"INT3404", }, /* Fan */

		{}

	};

	struct acpi_device *adev = ACPI_COMPANION(dev);



	if (!adev)

	if (!adev || !acpi_match_device_ids(adev, special_pm_ids))

		return 0;



	/*