Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 248470f3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

ALSA: hda: prevent undefined shift in snd_hdac_ext_bus_get_link() 



[ Upstream commit 158e1886b6262c1d1c96a18c85fac5219b8bf804 ]

This is harmless, but the "addr" comes from the user and it could lead
to a negative shift or to shift wrapping if it's too high.

Fixes: 0b00a561 ("ALSA: hdac_ext: add hdac extended controller")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20201103101807.GC1127762@mwanda


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5e6d8c98

sound/hda/ext/hdac_ext_controller.c

+2 −0
Original line number Diff line number Diff line
@@ -156,6 +156,8 @@ struct hdac_ext_link *snd_hdac_ext_bus_get_link(struct hdac_bus *bus, 
		return NULL;

	if (bus->idx != bus_idx)

		return NULL;

	if (addr < 0 || addr > 31)

		return NULL;



	list_for_each_entry(hlink, &bus->hlink_list, list) {

		for (i = 0; i < HDA_MAX_CODECS; i++) {