Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23cae492 authored by Dan Carpenter's avatar Dan Carpenter Committed by Sudeep Holla
Browse files

firmware: arm_scmi: remove some unnecessary checks 



The "pi->dom_info" buffer is allocated in init() and it can't be NULL
here.  These tests are sort of weird as well because if "pi->dom_info"
was NULL but "domain" was non-zero then it would lead to an Oops.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent ce397d21

drivers/firmware/arm_scmi/perf.c

+0 −5
Original line number Diff line number Diff line
@@ -363,8 +363,6 @@ static int scmi_dvfs_device_opps_add(const struct scmi_handle *handle, 
		return domain;



	dom = pi->dom_info + domain;

	if (!dom)

		return -EIO;



	for (opp = dom->opp, idx = 0; idx < dom->opp_count; idx++, opp++) {

		freq = opp->perf * dom->mult_factor;
@@ -394,9 +392,6 @@ static int scmi_dvfs_transition_latency_get(const struct scmi_handle *handle, 
		return domain;



	dom = pi->dom_info + domain;

	if (!dom)

		return -EIO;



	/* uS to nS */

	return dom->opp[dom->opp_count - 1].trans_latency_us * 1000;

}