Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 239795ad authored by Ben Hutchings's avatar Ben Hutchings Committed by David S. Miller
Browse files

sfc: Use correct macro to set event bitfield 



falcon_sim_phy_event() used EFX_OWORD_FIELD, which operates on
bitfields in 128-bit values, on an event, which is a 64-bit value.
This should be harmless - these macros always use little-endian
ordering, so it would read and write back the following 8 bytes
unchanged - but it is obviously wrong.

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 718cff1e

drivers/net/sfc/falcon.c

+2 −2
Original line number Diff line number Diff line
@@ -1176,9 +1176,9 @@ void falcon_sim_phy_event(struct efx_nic *efx) 


	EFX_POPULATE_QWORD_1(phy_event, EV_CODE, GLOBAL_EV_DECODE);

	if (EFX_IS10G(efx))

		EFX_SET_OWORD_FIELD(phy_event, XG_PHY_INTR, 1);

		EFX_SET_QWORD_FIELD(phy_event, XG_PHY_INTR, 1);

	else

		EFX_SET_OWORD_FIELD(phy_event, G_PHY0_INTR, 1);

		EFX_SET_QWORD_FIELD(phy_event, G_PHY0_INTR, 1);



	falcon_generate_event(&efx->channel[0], &phy_event);

}