Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23936ba9 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Tomi Valkeinen
Browse files

drm/omap: Use normalized zpos for plane placement 



Planes with identical zpos value will result undefined behavior:
disappearing planes, screen flickering and it is not supported by the
hardware.

Use normalized zpos to make sure that we don't encounter invalid
configuration.

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
CC: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180321102029.15248-7-peter.ujfalusi@ti.com
parent 75def778

drivers/gpu/drm/omapdrm/omap_drv.c

+3 −0
Original line number Diff line number Diff line
@@ -319,6 +319,9 @@ static int omap_modeset_init(struct drm_device *dev) 
	dev->mode_config.max_width = 8192;

	dev->mode_config.max_height = 8192;



	/* We want the zpos to be normalized */

	dev->mode_config.normalize_zpos = true;



	dev->mode_config.funcs = &omap_mode_config_funcs;

	dev->mode_config.helper_private = &omap_mode_config_helper_funcs;

drivers/gpu/drm/omapdrm/omap_plane.c

+1 −1
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ static void omap_plane_atomic_update(struct drm_plane *plane, 
	info.rotation_type = OMAP_DSS_ROT_NONE;

	info.rotation = DRM_MODE_ROTATE_0;

	info.global_alpha = 0xff;

	info.zorder = state->zpos;

	info.zorder = state->normalized_zpos;



	/* update scanout: */

	omap_framebuffer_update_scanout(state->fb, state, &info);