Commit 2388bd7b authored Jun 14, 2017 by Dan Carpenter Committed by Luca Coelho Jul 21, 2017

iwlwifi: missing error code in iwl_trans_pcie_alloc()



We don't set the error code here so we end up returning ERR_PTR(0) which
is NULL.  The caller doesn't expect that so it results in a NULL
dereference.

Fixes: 2e5d4a8f ("iwlwifi: pcie: Add new configuration to enable MSIX")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

parent 61dd8a8a

drivers/net/wireless/intel/iwlwifi/pcie/trans.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -3150,7 +3150,8 @@ struct iwl_trans iwl_trans_pcie_alloc(struct pci_dev pdev,
		init_waitqueue_head(&trans_pcie->d0i3_waitq);

		if (trans_pcie->msix_enabled) {
		if (iwl_pcie_init_msix_handler(pdev, trans_pcie))
		ret = iwl_pcie_init_msix_handler(pdev, trans_pcie);
		if (ret)
		goto out_no_pci;
		} else {
		ret = iwl_pcie_alloc_ict(trans);