Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23677ce3 authored by Joe Perches's avatar Joe Perches Committed by David S. Miller
Browse files

drivers/net: Remove boolean comparisons to true/false 



Booleans should not be compared to true or false
but be directly tested or tested with !.

Done via cocci script:

@@
bool t;
@@
- t == true
+ t
@@
bool t;
@@
- t != true
+ !t
@@
bool t;
@@
- t == false
+ !t
@@
bool t;
@@
- t != false
+ t

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reviewed-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1a0d6ae5

drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h

+1 −2
Original line number Diff line number Diff line
@@ -614,8 +614,7 @@ static inline void bnx2x_igu_clear_sb_gen(struct bnx2x *bp, u8 func, 
	u32 igu_addr_ctl = IGU_REG_COMMAND_REG_CTRL;

	u32 igu_addr_ack = IGU_REG_CSTORM_TYPE_0_SB_CLEANUP + (idu_sb_id/32)*4;

	u32 sb_bit =  1 << (idu_sb_id%32);

	u32 func_encode = func |

			((is_Pf == true ? 1 : 0) << IGU_FID_ENCODE_IS_PF_SHIFT);

	u32 func_encode = func | (is_Pf ? 1 : 0) << IGU_FID_ENCODE_IS_PF_SHIFT;

	u32 addr_encode = IGU_CMD_E2_PROD_UPD_BASE + idu_sb_id;



	/* Not supported in BC mode */

drivers/net/ethernet/brocade/bna/bfa_cee.c

+4 −4
Original line number Diff line number Diff line
@@ -203,7 +203,7 @@ bfa_nw_cee_get_attr(struct bfa_cee *cee, struct bfa_cee_attr *attr, 
	if (!bfa_nw_ioc_is_operational(cee->ioc))

		return BFA_STATUS_IOC_FAILURE;



	if (cee->get_attr_pending == true)

	if (cee->get_attr_pending)

		return  BFA_STATUS_DEVBUSY;



	cee->get_attr_pending = true;
@@ -272,7 +272,7 @@ bfa_cee_notify(void *arg, enum bfa_ioc_event event) 
	switch (event) {

	case BFA_IOC_E_DISABLED:

	case BFA_IOC_E_FAILED:

		if (cee->get_attr_pending == true) {

		if (cee->get_attr_pending) {

			cee->get_attr_status = BFA_STATUS_FAILED;

			cee->get_attr_pending  = false;

			if (cee->cbfn.get_attr_cbfn) {
@@ -281,7 +281,7 @@ bfa_cee_notify(void *arg, enum bfa_ioc_event event) 
					BFA_STATUS_FAILED);

			}

		}

		if (cee->get_stats_pending == true) {

		if (cee->get_stats_pending) {

			cee->get_stats_status = BFA_STATUS_FAILED;

			cee->get_stats_pending  = false;

			if (cee->cbfn.get_stats_cbfn) {
@@ -290,7 +290,7 @@ bfa_cee_notify(void *arg, enum bfa_ioc_event event) 
					BFA_STATUS_FAILED);

			}

		}

		if (cee->reset_stats_pending == true) {

		if (cee->reset_stats_pending) {

			cee->reset_stats_status = BFA_STATUS_FAILED;

			cee->reset_stats_pending  = false;

			if (cee->cbfn.reset_stats_cbfn) {

drivers/net/ethernet/brocade/bna/bfa_ioc.c

+1 −1
Original line number Diff line number Diff line
@@ -692,7 +692,7 @@ static void 
bfa_iocpf_sm_mismatch_entry(struct bfa_iocpf *iocpf)

{

	/* Call only the first time sm enters fwmismatch state. */

	if (iocpf->fw_mismatch_notified == false)

	if (!iocpf->fw_mismatch_notified)

		bfa_ioc_pf_fwmismatch(iocpf->ioc);



	iocpf->fw_mismatch_notified = true;

drivers/net/ethernet/intel/ixgb/ixgb_ee.c

+5 −7
Original line number Diff line number Diff line
@@ -533,10 +533,8 @@ __le16 
ixgb_get_eeprom_word(struct ixgb_hw *hw, u16 index)

{



	if ((index < IXGB_EEPROM_SIZE) &&

		(ixgb_check_and_get_eeprom_data(hw) == true)) {

	if (index < IXGB_EEPROM_SIZE && ixgb_check_and_get_eeprom_data(hw))

		return hw->eeprom[index];

	}



	return 0;

}
@@ -558,7 +556,7 @@ ixgb_get_ee_mac_addr(struct ixgb_hw *hw, 


	ENTER();



	if (ixgb_check_and_get_eeprom_data(hw) == true) {

	if (ixgb_check_and_get_eeprom_data(hw)) {

		for (i = 0; i < ETH_ALEN; i++) {

			mac_addr[i] = ee_map->mac_addr[i];

		}
@@ -578,7 +576,7 @@ ixgb_get_ee_mac_addr(struct ixgb_hw *hw, 
u32

ixgb_get_ee_pba_number(struct ixgb_hw *hw)

{

	if (ixgb_check_and_get_eeprom_data(hw) == true)

	if (ixgb_check_and_get_eeprom_data(hw))

		return le16_to_cpu(hw->eeprom[EEPROM_PBA_1_2_REG])

			| (le16_to_cpu(hw->eeprom[EEPROM_PBA_3_4_REG])<<16);
@@ -599,7 +597,7 @@ ixgb_get_ee_device_id(struct ixgb_hw *hw) 
{

	struct ixgb_ee_map_type *ee_map = (struct ixgb_ee_map_type *)hw->eeprom;



	if (ixgb_check_and_get_eeprom_data(hw) == true)

	if (ixgb_check_and_get_eeprom_data(hw))

		return le16_to_cpu(ee_map->device_id);



	return 0;

drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c

+2 −2
Original line number Diff line number Diff line
@@ -617,7 +617,7 @@ static s32 ixgbe_check_mac_link_82598(struct ixgbe_hw *hw, 
				*link_up = false;

		}



		if (*link_up == false)

		if (!*link_up)

			goto out;

	}
@@ -645,7 +645,7 @@ static s32 ixgbe_check_mac_link_82598(struct ixgbe_hw *hw, 
	else

		*speed = IXGBE_LINK_SPEED_1GB_FULL;



	if ((hw->device_id == IXGBE_DEV_ID_82598AT2) && (*link_up == true) &&

	if ((hw->device_id == IXGBE_DEV_ID_82598AT2) && *link_up &&

	    (ixgbe_validate_link_ready(hw) != 0))

		*link_up = false;