Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2354161d authored by Cindy H Kao's avatar Cindy H Kao Committed by Inaky Perez-Gonzalez
Browse files

wimax/i2400m: Correct the error path handlers order in i2400m_post_reset() 



When bus_setup fails in i2400m_post_reset(), it falls to the error path handler
"error_bus_setup:" which includes unlock the mutext. However, we didn't ever
try to the obtain the lock when running bus_setup.

The patch is to fix the misplaced error path handler "error_bus_setup:".

Signed-off-by: default avatarCindy H Kao <cindy.h.kao@intel.com>
parent 599e5953

drivers/net/wimax/i2400m/driver.c

+1 −1
Original line number Diff line number Diff line
@@ -629,12 +629,12 @@ int i2400m_post_reset(struct i2400m *i2400m) 
error_dev_start:

	if (i2400m->bus_release)

		i2400m->bus_release(i2400m);

error_bus_setup:

	/* even if the device was up, it could not be recovered, so we

	 * mark it as down. */

	i2400m->updown = 0;

	wmb();		/* see i2400m->updown's documentation  */

	mutex_unlock(&i2400m->init_mutex);

error_bus_setup:

	d_fnend(3, dev, "(i2400m %p) = %d\n", i2400m, result);

	return result;

}