Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 232ef6bc authored by Emil Tantilov's avatar Emil Tantilov Committed by Jeff Kirsher
Browse files

ixgbe: Fix link issues caused by a reset while interface is down 



Interface fails to obtain link on 82599 SFP in the following scenario:

1. Set advertised speed to GB:
ethtool -s eth0 advertise 0x20

2. Bring interface down
ip link set eth0 down

3. Issue any command that leads to a reset:
ethtool -t eth0

4. Bring link back up:
ip link set eth0 up

Following patch makes sure that the driver flaps the Tx laser every time
ixgbe_start_hw() is called, and not only when the speed is set.

Signed-off-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Tested-by: default avatarPhil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent d5a0e364

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+0 −1
Original line number Diff line number Diff line
@@ -6125,7 +6125,6 @@ static void ixgbe_sfp_link_config_subtask(struct ixgbe_adapter *adapter) 
	autoneg = hw->phy.autoneg_advertised;

	if ((!autoneg) && (hw->mac.ops.get_link_capabilities))

		hw->mac.ops.get_link_capabilities(hw, &autoneg, &negotiation);

	hw->mac.autotry_restart = false;

	if (hw->mac.ops.setup_link)

		hw->mac.ops.setup_link(hw, autoneg, negotiation, true);