Commit 230ffc8e authored May 22, 2007 by Semih Hazar Committed by Dmitry Torokhov May 22, 2007

Input: ads7846 - SPI_CPHA mode bugfix

In commit [1] the SPI mode is set to 1, but it should be 0.  As stated
in the commit, ads784x samples the data on the rising edge.  SPI mode 1
samples on the falling edge [2] though.

The root cause of this is a bug in the omap_uwire code, which treats
CPHA=1 incorrectly; so these two bugs cancel each other out on one
of the main regression test platforms for this driver.

[1] kernel.org GIT 7937e86a
[2] http://en.wikipedia.org/wiki/Serial_Peripheral_Interface_Bus



Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

parent bff0de5f

drivers/input/touchscreen/ads7846.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -848,7 +848,7 @@ static int __devinit ads7846_probe(struct spi_device *spi)
		* may not. So we stick to very-portable 8 bit words, both RX and TX.
		*/
		spi->bits_per_word = 8;
		spi->mode = SPI_MODE_1;
		spi->mode = SPI_MODE_0;
		err = spi_setup(spi);
		if (err < 0)
		return err;