Commit 2306a677 authored Mar 02, 2018 by Tobin C. Harding

leaking_addresses: explicitly name variable used in regex



Currently sub routine may_leak_address() is checking regex against Perl
special variable $_ which is _fortunately_ being set correctly in a loop
before this sub routine is called.  We already have declared a variable
to hold this value '$line' we should use it.

Use $line in regex match instead of implicit $_

Signed-off-by: Tobin C. Harding <me@tobin.cc>

parent 34827374

scripts/leaking_addresses.pl

+1 −1

Original line number	Diff line number	Diff line
		@@ -363,7 +363,7 @@ sub may_leak_address
		}

		$address_re = get_address_re();
		while (/($address_re)/g) {
		while ($line =~ /($address_re)/g) {
		if (!is_false_positive($1)) {
		return 1;
		}