Commit 22400674 authored May 09, 2014 by Michael Kerrisk Committed by Ingo Molnar May 22, 2014

sched: Simplify return logic in sched_read_attr()



Gotos are chained pointlessly here, and the 'out' label
can be dispensed with.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/536CEC29.9090503@gmail.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent e78c7bca

kernel/sched/core.c

+2 −7

Original line number	Diff line number	Diff line
		@@ -3821,7 +3821,7 @@ static int sched_read_attr(struct sched_attr __user *uattr,

		for (; addr < end; addr++) {
		if (*addr)
		goto err_size;
		return -EFBIG;
		}

		attr->size = usize;
		@@ -3831,12 +3831,7 @@ static int sched_read_attr(struct sched_attr __user *uattr,
		if (ret)
		return -EFAULT;

		out:
		return ret;

		err_size:
		ret = -E2BIG;
		goto out;
		return 0;
		}

		/**