Commit 21ddba19 authored Jul 04, 2016 by Andy Shevchenko Committed by Mark Brown Jul 04, 2016

spi: pxa2xx-pci: Remove unused code



pcim_iomap_table() can't fail when called after pcim_iomap_regions(). Moreover,
we already dereference returned value and kernel will crash if it is not
correct.

Remove obvious leftover of commit 0202775b ("spi/pxa2xx-pci: switch to use
pcim_* interfaces").

Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 4f470910

drivers/spi/spi-pxa2xx-pci.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -202,10 +202,6 @@ static int pxa2xx_spi_pci_probe(struct pci_dev *dev,
		ssp = &spi_pdata.ssp;
		ssp->phys_base = pci_resource_start(dev, 0);
		ssp->mmio_base = pcim_iomap_table(dev)[0];
		if (!ssp->mmio_base) {
		dev_err(&dev->dev, "failed to ioremap() registers\n");
		return -EIO;
		}
		ssp->irq = dev->irq;
		ssp->port_id = (c->port_id >= 0) ? c->port_id : dev->devfn;
		ssp->type = c->type;