Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 21bea69c authored by Sudarshan Rajagopalan's avatar Sudarshan Rajagopalan
Browse files

ion: remove cpu binding of pool refill kthreads 



Remove the cpu affinity of ion pool refill kthreads which were
binded to min capability cpus, since there was no observable
power impact with when not affined.

Note: It was found that the code to create cpumask for min
capability cpus was broken and kthreads were free to run on
any cpus. No observable power impact was seen, hence better
off with removing this code entirely.

Change-Id: If6a32d9e4d3c576e63e3b0ec405be1fd4639a5e0
Signed-off-by: default avatarSudarshan Rajagopalan <sudaraja@codeaurora.org>
parent c511abcf

drivers/staging/android/ion/ion_system_heap.c

+1 −9
Original line number Diff line number Diff line
@@ -689,17 +689,9 @@ static struct task_struct *ion_create_kworker(struct ion_page_pool **pools, 
	struct task_struct *thread;

	int ret;

	char *buf;

	cpumask_t *cpumask;

	DECLARE_BITMAP(bmap, nr_cpumask_bits);



	attr.sched_nice = ION_KTHREAD_NICE_VAL;

	buf = cached ? "cached" : "uncached";

	/*

	 * Affine the kthreads to min capacity CPUs

	 * TODO: remove this hack once is_min_capability_cpu is available

	 */

	bitmap_fill(bmap, 0x4);

	cpumask = to_cpumask(bmap);



	thread = kthread_create(ion_sys_heap_worker, pools,

				"ion-pool-%s-worker", buf);
@@ -715,7 +707,7 @@ static struct task_struct *ion_create_kworker(struct ion_page_pool **pools, 
			__func__, buf, ret);

		return ERR_PTR(ret);

	}

	kthread_bind_mask(thread, cpumask);



	return thread;

}