Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 216ce296 authored by Okash Khawaja's avatar Okash Khawaja Committed by Greg Kroah-Hartman
Browse files

staging: speakup: safely close tty 



Speakup opens tty using tty_open_by_driver. When closing, it calls
tty_ldisc_release but doesn't close and remove the tty itself. As a
result, that tty cannot be opened from user space. This patch calls
tty_release_struct which ensures that tty is safely removed and freed
up. It also calls tty_ldisc_release, so speakup doesn't need to call it.

Signed-off-by: default avatarOkash Khawaja <okash.khawaja@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 740c433e

drivers/staging/speakup/spk_ttyio.c

+1 −1
Original line number Diff line number Diff line
@@ -300,7 +300,7 @@ void spk_ttyio_release(void) 


	tty_ldisc_flush(speakup_tty);

	tty_unlock(speakup_tty);

	tty_ldisc_release(speakup_tty);

	tty_release_struct(speakup_tty, speakup_tty->index);

}

EXPORT_SYMBOL_GPL(spk_ttyio_release);