Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 213972e9 authored by d binderman's avatar d binderman Committed by Benjamin Herrenschmidt
Browse files

powerpc/pmac/low_i2c.c: three minor problems 



Fix minor nits found by cppcheck

[./arch/powerpc/platforms/powermac/low_i2c.c:594]: (style) The scope of the variable chans can be reduced
[./arch/powerpc/platforms/powermac/low_i2c.c:594]: (style) The scope of the variable i can be reduced
[./arch/powerpc/platforms/powermac/low_i2c.c:1260]: (style) Redundant condition. It is safe to deallocate a NULL pointer

Signed-off-by: default avatarDavid Binderman <dcb314@hotmail.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 6237cdac

arch/powerpc/platforms/powermac/low_i2c.c

+4 −3
Original line number Diff line number Diff line
@@ -592,7 +592,7 @@ static void __init kw_i2c_probe(void) 
	/* Probe keywest-i2c busses */

	for_each_compatible_node(np, "i2c","keywest-i2c") {

		struct pmac_i2c_host_kw *host;

		int multibus, chans, i;

		int multibus;



		/* Found one, init a host structure */

		host = kw_i2c_host_init(np);
@@ -614,6 +614,8 @@ static void __init kw_i2c_probe(void) 
		 * parent type

		 */

		if (multibus) {

			int chans, i;



			parent = of_get_parent(np);

			if (parent == NULL)

				continue;
@@ -1258,7 +1260,6 @@ static void pmac_i2c_do_end(struct pmf_function *func, void *instdata) 
	if (inst == NULL)

		return;

	pmac_i2c_close(inst->bus);

	if (inst)

	kfree(inst);

}